From: Stefan Weil <weil@mail.berlios.de>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] eepro100: Remove unused device status entries
Date: Thu, 08 Oct 2009 21:19:04 +0200 [thread overview]
Message-ID: <4ACE3B28.6040207@mail.berlios.de> (raw)
In-Reply-To: <20091008190031.GA3496@miranda.arrow>
Stuart Brady schrieb:
> On Thu, Oct 08, 2009 at 08:15:37AM +0200, Stefan Weil wrote:
>
> [snip entertaining patch description]
>
>
>> - if (version_id >= 2) {
>> - qemu_get_8s(f, &s->rxcr);
>> - } else {
>> - s->rxcr = 0x0c;
>> - }
>> + /* Skip unused entries. */
>> + qemu_fseek(f, 32, SEEK_CUR);
>>
>
> Shouldn't the number of bytes skipped depend on the version ID?
>
> Cheers,
>
There was never a version id other than 3, so the "else" was junk.
The old code was a copy from ne2000.c, my original contribution
had marked it as work in progress.
Regards
Stefan
next prev parent reply other threads:[~2009-10-08 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-19 11:41 [Qemu-devel] [PATCH] eepro100: Remove unused device status entries Stefan Weil
[not found] ` <m3d45naqws.fsf@neno.mitica>
2009-09-19 15:58 ` [Qemu-devel] " Stefan Weil
2009-10-05 13:20 ` Anthony Liguori
2009-10-08 6:15 ` [Qemu-devel] " Stefan Weil
2009-10-08 19:00 ` Stuart Brady
2009-10-08 19:19 ` Stefan Weil [this message]
2009-10-09 17:49 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACE3B28.6040207@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=qemu-devel@nongnu.org \
--cc=sdbrady@ntlworld.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).