From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvyWM-0002A7-GK
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 15:19:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvyWG-00028l-IW
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 15:19:24 -0400
Received: from [199.232.76.173] (port=34796 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvyWG-00028i-BX
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 15:19:20 -0400
Received: from moutng.kundenserver.de ([212.227.126.188]:65030)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1MvyWF-0002Bq-48
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 15:19:20 -0400
Message-ID: <4ACE3B28.6040207@mail.berlios.de>
Date: Thu, 08 Oct 2009 21:19:04 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] eepro100: Remove unused device status entries
References: <4AC9F29B.5060404@codemonkey.ws>	<1254982537-6377-1-git-send-email-weil@mail.berlios.de>
	<20091008190031.GA3496@miranda.arrow>
In-Reply-To: <20091008190031.GA3496@miranda.arrow>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: qemu-devel@nongnu.org

Stuart Brady schrieb:
> On Thu, Oct 08, 2009 at 08:15:37AM +0200, Stefan Weil wrote:
>
> [snip entertaining patch description]
>
>   
>> -    if (version_id >= 2) {
>> -        qemu_get_8s(f, &s->rxcr);
>> -    } else {
>> -        s->rxcr = 0x0c;
>> -    }
>> +    /* Skip unused entries. */
>> +    qemu_fseek(f, 32, SEEK_CUR);
>>     
>
> Shouldn't the number of bytes skipped depend on the version ID?
>
> Cheers,
>   

There was never a version id other than 3, so the "else" was junk.
The old code was a copy from ne2000.c, my original contribution
had marked it as work in progress.

Regards
Stefan