From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MxIOZ-0002tr-Ra for qemu-devel@nongnu.org; Mon, 12 Oct 2009 06:44:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MxIOU-0002nV-Kc for qemu-devel@nongnu.org; Mon, 12 Oct 2009 06:44:50 -0400 Received: from [199.232.76.173] (port=59958 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MxIOU-0002nG-7J for qemu-devel@nongnu.org; Mon, 12 Oct 2009 06:44:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64923) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MxIOT-0003ZH-Pf for qemu-devel@nongnu.org; Mon, 12 Oct 2009 06:44:46 -0400 Message-ID: <4AD3085A.1050906@redhat.com> Date: Mon, 12 Oct 2009 12:43:38 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2] multiboot: Limit number of multiboot modules References: <1255268921-5403-1-git-send-email-adam@os.inf.tu-dresden.de> <1255268921-5403-2-git-send-email-adam@os.inf.tu-dresden.de> In-Reply-To: <1255268921-5403-2-git-send-email-adam@os.inf.tu-dresden.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: adam@os.inf.tu-dresden.de Cc: qemu-devel@nongnu.org Am 11.10.2009 15:48, schrieb adam@os.inf.tu-dresden.de: > From: Adam Lackorzynski > > Add size checks to avoid overwriting the multiboot structure > when too many modules are loaded. > > Signed-off-by: Adam Lackorzynski Acked-by: Kevin Wolf Looks correct, too, and is definitely an improvement over the current code. But can't we make it more dynamic in a second step? I don't like arbitrary fixed limits. Kevin