From: Anthony Liguori <anthony@codemonkey.ws>
To: Jamie Lokier <jamie@shareable.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Naphtali Sprei <nsprei@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add readonly flag to -drive command
Date: Mon, 12 Oct 2009 09:30:05 -0500 [thread overview]
Message-ID: <4AD33D6D.9020900@codemonkey.ws> (raw)
In-Reply-To: <20091012135032.GA13560@shareable.org>
Jamie Lokier wrote:
> Kevin Wolf wrote:
>
>> Am 12.10.2009 14:47, schrieb Naphtali Sprei:
>>
>>> In order to safely share an image between guests (as read only drive), add a 'readonly' flag
>>> to the -drive command (qemu command line and monitor).
>>>
>
> Heh. I've been sharing images between guests for ages - using "chmod -r" :-)
>
Were it not for backwards compatibility, I would remove that and have it
error out.
I've had multiple people end up with strangely broken guests because
they didn't realize the image was read only.
>>> Still missing passing the read only attribute to the guest, where possible. I don't know which device types supports
>>> read only, and don't know how to pass this information to guests.
>>>
>
> This was discussed in a thread some months ago. You might look it up.
> SCSI, USB, and floppy can pass the information to guests - see the
> Linux kernel for how the flag is read. CD-ROMs are read-only already
> of course. I don't know if virtio-blk can; if not, it would be good to
> add it.
>
virtio-blk can support read-only images now.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-10-12 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 12:47 [Qemu-devel] [PATCH] Add readonly flag to -drive command Naphtali Sprei
2009-10-12 13:24 ` Kevin Wolf
2009-10-12 13:50 ` Jamie Lokier
2009-10-12 14:07 ` Kevin Wolf
2009-10-12 14:30 ` Anthony Liguori [this message]
2009-10-12 15:16 ` Jamie Lokier
2009-10-12 16:15 ` Michael Tokarev
2009-10-13 7:36 ` Kevin Wolf
2009-10-12 14:06 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD33D6D.9020900@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=jamie@shareable.org \
--cc=kwolf@redhat.com \
--cc=nsprei@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).