From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mxdjc-00035p-KA for qemu-devel@nongnu.org; Tue, 13 Oct 2009 05:32:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MxdjW-00031D-MZ for qemu-devel@nongnu.org; Tue, 13 Oct 2009 05:31:59 -0400 Received: from [199.232.76.173] (port=40378 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MxdjV-00030z-PI for qemu-devel@nongnu.org; Tue, 13 Oct 2009 05:31:53 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:19568) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MxdjV-0003QJ-7P for qemu-devel@nongnu.org; Tue, 13 Oct 2009 05:31:53 -0400 Message-ID: <4AD4499C.7050106@siemens.com> Date: Tue, 13 Oct 2009 11:34:20 +0200 From: Wolfgang Mauerer MIME-Version: 1.0 References: <1253287576-12875-1-git-send-email-wolfgang.mauerer@siemens.com> <20091009163203.GA30218@redhat.com> <4AD44381.5020101@redhat.com> In-Reply-To: <4AD44381.5020101@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [libvirt] [PATCH 0/9] Support disk-hotremove and controller hotplugging List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "libvir-list@redhat.com" , "Kiszka, Jan" , "qemu-devel@nongnu.org" Hi, Gerd Hoffmann wrote: > On 10/09/09 18:32, Daniel Veillard wrote: >> On Fri, Sep 18, 2009 at 05:26:07PM +0200, Wolfgang Mauerer wrote: >>> Hi, >> Hi Wolfgang, >> >>> this patch reworks libvirt's disk-hotadd support and >>> introduces support for disk controller hotplugging and disk-hotremove >>> (see http://thread.gmane.org/gmane.comp.emulators.libvirt/15860 for >>> more details). Currently, it targets only qemu and also requires some >>> additions to qemu that have only recently been submitted, which is >>> why this is cross-posted to qemu-devel. Hopefully the lack of support >>> in qemu does not prevent the community from reviewing the code, >>> though ;-) >> Could you update us on the status for those patches, is there >> any chance to get this in QEmu upstream ? I have only seen feddback >> from Gerd Hoffmann on that thread but maybe I'm missing some of the >> action ! sorry, I did not get that mail for some reason, so I did not reply. > > Note: upstream qemu got device_add and device_del monitor commands > meanwhile which can be used to hotplug devices. > > device_add accepts the same syntax the -device command line switch expects. > > device_del expectes an id. > > For libvirt it probably makes sense to start supporting this when > switching over to -device (probably for qemu 0.12+). Since it does most likely not make sense to include my drive_del implementation into qemu 0.11 mainline, I'll add libvirt support for these after I finish doing the structural changes suggested by Daniel Berrange. Cheers, Wolfgang