From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mxhi5-0007uU-2q for qemu-devel@nongnu.org; Tue, 13 Oct 2009 09:46:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mxhi0-0007u2-SE for qemu-devel@nongnu.org; Tue, 13 Oct 2009 09:46:40 -0400 Received: from [199.232.76.173] (port=49891 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mxhi0-0007ts-N4 for qemu-devel@nongnu.org; Tue, 13 Oct 2009 09:46:36 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:57248) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mxhhz-0003ov-Rp for qemu-devel@nongnu.org; Tue, 13 Oct 2009 09:46:36 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e38.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n9DDg5vQ020868 for ; Tue, 13 Oct 2009 07:42:05 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9DDk9fN067646 for ; Tue, 13 Oct 2009 07:46:11 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n9DDk56E013913 for ; Tue, 13 Oct 2009 07:46:06 -0600 Message-ID: <4AD4849C.3000600@us.ibm.com> Date: Tue, 13 Oct 2009 08:46:04 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1255434008.1817.40.camel@localhost.localdomain> In-Reply-To: <1255434008.1817.40.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] usb-linux: return USB_RET_STALL on -EPIPE List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Bolle Cc: Mark Burkley , qemu-devel@nongnu.org, Max Krasnyansky Paul Bolle wrote: > 0) This is an attempt to get an issue in usb-linux.c, for which a patch > was posted about a year ago, finally fixed. > > 1) Mark Burkley submitted a "EHCI emulation module" for review in in > October 2008 (see: > http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg01326.html). No > EHCI emulation module was ever committed to qemu. > Yeah, it's ashame that noone's followed up with this patch. > 2) Part of that (large) patch was a fix for a separate issue in > usb-linux.c. Max Krasnyansky has ACK'ed that fix (see: > http://lists.gnu.org/archive/html/qemu-devel/2008-11/msg00032.html). > > 3) I already asked whether this fix was ready to be committed in last > April (see: > http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01763.html) > > 4) Maybe submitting this fix as a separate patch (with a really long > commit message but without a Signed-off-by) and cc-ing everbody involved > will help if actually getting this issue fixed. > Yes, separate fixes should always be separate patches. > Ok. I just tested that change (ie returning STALL instead of NAK on EPIPE) > with a bunch of devices: USB serial adapter, CF card reader, USB webcam (MS > VX-3000) and MS USB mouse. All that stuff was hooked up to XP-SP3 and all of > them are perfectly usable at the same time. > > In other words here is my ACK :) > > Acked-by: Max Krasnyansky > Tested-by: Paul Bolle > Someone needs to provide a Signed-off-by. > --- > usb-linux.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/usb-linux.c b/usb-linux.c > index 9e5d9c4..d712134 100644 > --- a/usb-linux.c > +++ b/usb-linux.c > @@ -275,7 +275,9 @@ static void async_complete(void *opaque) > > case -EPIPE: > set_halt(s, p->devep); > - /* fall through */ > + p->len = USB_RET_STALL; > + break; > + > default: > p->len = USB_RET_NAK; > break; > -- Regards, Anthony Liguori