From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MxjJV-0001QA-D9
	for qemu-devel@nongnu.org; Tue, 13 Oct 2009 11:29:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MxjJQ-0001Mo-Dd
	for qemu-devel@nongnu.org; Tue, 13 Oct 2009 11:29:24 -0400
Received: from [199.232.76.173] (port=60314 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MxjJQ-0001Mi-9S
	for qemu-devel@nongnu.org; Tue, 13 Oct 2009 11:29:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27802)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MxjJP-0004lS-Jr
	for qemu-devel@nongnu.org; Tue, 13 Oct 2009 11:29:19 -0400
Message-ID: <4AD49CCB.5060600@redhat.com>
Date: Tue, 13 Oct 2009 17:29:15 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/4] rom loader: make vga+rom loading target
	specific
References: <1255431978-4992-1-git-send-email-kraxel@redhat.com>
	<1255431978-4992-3-git-send-email-kraxel@redhat.com>
	<f43fc5580910130758w47a2b296yd54e3552478c4823@mail.gmail.com>
In-Reply-To: <f43fc5580910130758w47a2b296yd54e3552478c4823@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 10/13/09 16:58, Blue Swirl wrote:
> On Tue, Oct 13, 2009 at 2:06 PM, Gerd Hoffmann<kraxel@redhat.com>  wrote:
>> This patch adds a loader-target.c file for target-specific
>> rom loading functions.  The rom_add_vga() and rom_add_option()
>> macros are transformed into functions and sticked in there.  They
>> load the bios on TARGET_I386 and no nothing on other targets.
>
> IIRC the VGA cards on non-x86 machines contain ROMs too, some (PPC?
> Alpha?) machine had a simple x86 emulator just to run the ROM code.
> Then you could enable the VGA ROM loading unconditionally. So maybe
> the patch isn't necessary?

Is the vgabios actually loaded to 0xc0000 (like x86 does) or does it 
just sit in the PCI ROM bar?

> Otherwise you could add two files without macros, then the files can
> be compiled just once.

... with lot of Makefile.target changes which I wanted to avoid.

Or is there a simple way to say "all but i386 please use $thisfile.c"?

cheers,
   Gerd