From: Gerd Hoffmann <kraxel@redhat.com>
To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] use rom loader for pc bios.
Date: Wed, 14 Oct 2009 09:31:33 +0200 [thread overview]
Message-ID: <4AD57E55.9050308@redhat.com> (raw)
In-Reply-To: <4AD4D966.8040005@gmx.net>
>> bios_offset = qemu_ram_alloc(bios_size);
>> - ret = load_image(filename, qemu_get_ram_ptr(bios_offset));
>> - if (ret != bios_size) {
>> + ret = rom_add_file_fixed(bios_name, (uint32_t)(-bios_size));
>>
>
> Memory leak?
I don't think so.
> AFAICS the qemu_ram_alloc above should be removed and maybe
> bios_offset needs to be killed completely.
Why? You still need the memory for the bios rom, even if the way it
gets loaded changes.
cheers,
Gerd
next prev parent reply other threads:[~2009-10-14 7:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 11:06 [Qemu-devel] [PATCH 0/4] more rom loader patches Gerd Hoffmann
2009-10-13 11:06 ` [Qemu-devel] [PATCH 1/4] rom loader: use qemu_strdup Gerd Hoffmann
2009-10-13 11:06 ` [Qemu-devel] [PATCH 2/4] rom loader: make vga+rom loading target specific Gerd Hoffmann
2009-10-13 14:58 ` Blue Swirl
2009-10-13 15:29 ` Gerd Hoffmann
2009-10-13 16:45 ` Blue Swirl
2009-10-14 7:28 ` Gerd Hoffmann
2009-10-13 22:03 ` Natalia Portillo
2009-10-14 10:21 ` Gerd Hoffmann
2009-10-14 12:37 ` Natalia Portillo
2009-10-13 11:06 ` [Qemu-devel] [PATCH 3/4] vga roms: move loading from pc.c to vga drivers Gerd Hoffmann
2009-10-13 11:06 ` [Qemu-devel] [PATCH 4/4] use rom loader for pc bios Gerd Hoffmann
2009-10-13 19:47 ` Carl-Daniel Hailfinger
2009-10-14 7:31 ` Gerd Hoffmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-16 14:04 [Qemu-devel] [PATCH v2 0/4] more rom loader patches Gerd Hoffmann
2009-10-16 14:04 ` [Qemu-devel] [PATCH 4/4] use rom loader for pc bios Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD57E55.9050308@redhat.com \
--to=kraxel@redhat.com \
--cc=c-d.hailfinger.devel.2006@gmx.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).