From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1My5AV-0008Rs-Rn for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:49:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1My5AQ-0008Qm-LM for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:49:34 -0400 Received: from [199.232.76.173] (port=39000 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1My5AQ-0008QW-D1 for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:49:30 -0400 Received: from mail-fx0-f214.google.com ([209.85.220.214]:38737) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1My5AP-0005kq-Te for qemu-devel@nongnu.org; Wed, 14 Oct 2009 10:49:30 -0400 Received: by fxm10 with SMTP id 10so10550356fxm.8 for ; Wed, 14 Oct 2009 07:49:29 -0700 (PDT) Message-ID: <4AD5E4F1.4080009@codemonkey.ws> Date: Wed, 14 Oct 2009 09:49:21 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [STABLE PATCH] hotplug: fix scsi hotplug. References: <1255527031-19008-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1255527031-19008-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann wrote: > Well, partly just papering over the issues. But without proper scsi bus > infrastructure we hardly can do better. Changes: > > * Avoid auto-attach by setting the bus number to -1. > * Ignore the unit value calculated by drive_init(). > * Explicitly attach the devices to the adapter. > * Add sanity checks. Don't allow attaching scsi drives to your > network device. > * Kill the bus+unit printing. The values are bogus, and we can't > easily figure the correct ones. I doubt this ever worked correctly > with multiple scsi adapters present in the system. > > Should come more close to the expected behavior now ... > > Oh, and pc-bios/bios.bin needs a update too, otherwise pci hotplug > doesn't work at all. > What's it being updated to? Regards, Anthony Liguori