qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Kusanagi Kouichi <slash@ac.auone-net.jp>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add chardev option to disable signal.
Date: Fri, 16 Oct 2009 09:04:51 -0500	[thread overview]
Message-ID: <4AD87D83.5040707@codemonkey.ws> (raw)
In-Reply-To: <20091016133139.9D5E715C033@msa104.auone-net.jp>

Kusanagi Kouichi wrote:
> If I am using vga and serial which is stdio and hit C-c on
> serial console, qemu terminates. That is annoying for me.
> So make it configurable whether signal is generated when C-c is hit.
>
> Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
> ---
>  qemu-char.c   |    6 +++---
>  qemu-config.c |    3 +++
>  2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 8084a67..dd23e63 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -727,7 +727,7 @@ static void term_exit(void)
>      fcntl(0, F_SETFL, old_fd0_flags);
>  }
>  
> -static void term_init(void)
> +static void term_init(QemuOpts *opts)
>  {
>      struct termios tty;
>  
> @@ -740,7 +740,7 @@ static void term_init(void)
>      tty.c_oflag |= OPOST;
>      tty.c_lflag &= ~(ECHO|ECHONL|ICANON|IEXTEN);
>      /* if graphical mode, we allow Ctrl-C handling */
> -    if (display_type == DT_NOGRAPHIC)
> +    if (!qemu_opt_get_bool(opts, "signal", display_type != DT_NOGRAPHIC))
>          tty.c_lflag &= ~ISIG;
>   

Would be nice to eliminate the DT_NOGRAPHIC check here.  In fact, 
looking at the other nographic check, they look bogus.

So how about eliminating DT_NOGRAPHIC entirely and replacing it with 
DT_NONE + appropriate serial config?

Regards,

Anthony Liguori

  reply	other threads:[~2009-10-16 14:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16 13:31 [Qemu-devel] [PATCH] Add chardev option to disable signal Kusanagi Kouichi
2009-10-16 14:04 ` Anthony Liguori [this message]
2009-10-17 10:59   ` Kusanagi Kouichi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD87D83.5040707@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=slash@ac.auone-net.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).