From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myqbv-0000cf-Pm for qemu-devel@nongnu.org; Fri, 16 Oct 2009 13:29:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myqbq-0000WX-WA for qemu-devel@nongnu.org; Fri, 16 Oct 2009 13:29:03 -0400 Received: from [199.232.76.173] (port=44241 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myqbq-0000WO-NE for qemu-devel@nongnu.org; Fri, 16 Oct 2009 13:28:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10177) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Myqbq-0003dC-9i for qemu-devel@nongnu.org; Fri, 16 Oct 2009 13:28:58 -0400 Message-ID: <4AD8AD4F.4070403@redhat.com> Date: Fri, 16 Oct 2009 19:28:47 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1255453026-18637-1-git-send-email-lcapitulino@redhat.com> <1255453026-18637-7-git-send-email-lcapitulino@redhat.com> <1255561330.29192.2.camel@slab.beaverton.ibm.com> <20091015103405.591e2f3b@doriath> <1255626960.29192.7.camel@slab.beaverton.ibm.com> <20091015145208.1d871f09@doriath> <1255630433.29192.16.camel@slab.beaverton.ibm.com> <20091015160839.7dbef5bf@doriath> <4AD8211B.9090004@redhat.com> <4AD87735.2030509@us.ibm.com> <20091016111727.3e63112c@doriath> In-Reply-To: <20091016111727.3e63112c@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 6/9] QError: Add qdev not found error List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , hollisb@linux.vnet.ibm.com, qemu-devel@nongnu.org, Gerd Hoffmann On 10/16/2009 04:17 PM, Luiz Capitulino wrote: > Second, I fear we are going too far with the objects idea. It > solves the monitor's problem well and although can be used by > other subsystems I wonder if pushing them to the extreme like that > is the way to go. I think that in practice Anthony is asking you only to write the stringified enum name (e.g. "QEMU_ERROR_NODEV"), instead of the enum value (i.e. 2). :-) I agree about what the immediate needs are. On the other hand, making things too complicated to extend later is not a good idea... Paolo, who's amazed at the amount of design changes that went into QEMU since last June...