From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myquk-0004Kl-VD for qemu-devel@nongnu.org; Fri, 16 Oct 2009 13:48:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myquf-0004H0-KQ for qemu-devel@nongnu.org; Fri, 16 Oct 2009 13:48:29 -0400 Received: from [199.232.76.173] (port=59354 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myquf-0004GZ-9w for qemu-devel@nongnu.org; Fri, 16 Oct 2009 13:48:25 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:59674) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Myque-000775-KE for qemu-devel@nongnu.org; Fri, 16 Oct 2009 13:48:24 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e36.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n9GHkGpr011261 for ; Fri, 16 Oct 2009 11:46:16 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9GHlxDV216846 for ; Fri, 16 Oct 2009 11:48:00 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n9GHloZh028020 for ; Fri, 16 Oct 2009 11:47:59 -0600 Message-ID: <4AD8B1C0.3010701@us.ibm.com> Date: Fri, 16 Oct 2009 12:47:44 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1255453026-18637-1-git-send-email-lcapitulino@redhat.com> <1255453026-18637-7-git-send-email-lcapitulino@redhat.com> <1255561330.29192.2.camel@slab.beaverton.ibm.com> <20091015103405.591e2f3b@doriath> <1255626960.29192.7.camel@slab.beaverton.ibm.com> <20091015145208.1d871f09@doriath> <1255630433.29192.16.camel@slab.beaverton.ibm.com> <20091015160839.7dbef5bf@doriath> <4AD8211B.9090004@redhat.com> <4AD87735.2030509@us.ibm.com> <20091016111727.3e63112c@doriath> <4AD8AD4F.4070403@redhat.com> In-Reply-To: <4AD8AD4F.4070403@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 6/9] QError: Add qdev not found error List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: hollisb@linux.vnet.ibm.com, Gerd Hoffmann , qemu-devel@nongnu.org, Luiz Capitulino Paolo Bonzini wrote: > On 10/16/2009 04:17 PM, Luiz Capitulino wrote: >> Second, I fear we are going too far with the objects idea. It >> solves the monitor's problem well and although can be used by >> other subsystems I wonder if pushing them to the extreme like that >> is the way to go. > > I think that in practice Anthony is asking you only to write the > stringified enum name (e.g. "QEMU_ERROR_NODEV"), instead of the enum > value (i.e. 2). :-) Yup. > I agree about what the immediate needs are. On the other hand, making > things too complicated to extend later is not a good idea... There are just a few things we have to get right and we should take our time on those. The error semantics are one of those important things that we'll regret in the future if we rush. -- Regards, Anthony Liguori