From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MyxQz-0000KQ-OJ
	for qemu-devel@nongnu.org; Fri, 16 Oct 2009 20:46:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MyxQv-0000Ho-BB
	for qemu-devel@nongnu.org; Fri, 16 Oct 2009 20:46:13 -0400
Received: from [199.232.76.173] (port=38446 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MyxQv-0000Hl-6E
	for qemu-devel@nongnu.org; Fri, 16 Oct 2009 20:46:09 -0400
Received: from mail-fx0-f211.google.com ([209.85.220.211]:37894)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1MyxQu-0001ZD-OO
	for qemu-devel@nongnu.org; Fri, 16 Oct 2009 20:46:08 -0400
Received: by fxm7 with SMTP id 7so2971694fxm.34
	for <qemu-devel@nongnu.org>; Fri, 16 Oct 2009 17:46:07 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4AD913CD.7050301@gnu.org>
Date: Sat, 17 Oct 2009 02:46:05 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 01/10] Introduce qmisc module
References: <1255037747-3340-1-git-send-email-lcapitulino@redhat.com>
	<1255037747-3340-2-git-send-email-lcapitulino@redhat.com>
	<4AD72B88.2040107@codemonkey.ws> <20091015122622.1f93ea2d@doriath>
	<20091015163936.GB532@redhat.com> <20091015142837.6c90580a@doriath>
	<4AD76B3C.3050001@codemonkey.ws> <4AD87424.3010000@redhat.com>
	<4AD87901.5030705@codemonkey.ws> <4AD8AECE.9000507@redhat.com>
	<4AD8AFA4.4070203@codemonkey.ws> <4AD8CB31.9080809@redhat.com>
	<4AD8E7B5.8000509@codemonkey.ws> <4AD910BA.4090607@gnu.org>
	<Pine.LNX.4.64.0910170438010.3915@linmac.oyster.ru>
In-Reply-To: <Pine.LNX.4.64.0910170438010.3915@linmac.oyster.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 10/17/2009 02:38 AM, malc wrote:
> a. allocation can fail

s/malloc/qemu_malloc/ etc. when it is time to merge.

> b. strtod is locale dependent

Right, but qemu probably would prefer to always do setlocale 
(LC_NUMERIC, "C"), or add a c_strtod function like

http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob_plain;f=lib/c-strtod.c

Thanks for the review, any additional pair of eyes can only help.

Paolo