From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mz4cH-0000cK-5B
	for qemu-devel@nongnu.org; Sat, 17 Oct 2009 04:26:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mz4cC-0000bf-CJ
	for qemu-devel@nongnu.org; Sat, 17 Oct 2009 04:26:20 -0400
Received: from [199.232.76.173] (port=51274 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mz4cC-0000bc-7V
	for qemu-devel@nongnu.org; Sat, 17 Oct 2009 04:26:16 -0400
Message-ID: <4AD976C1.3000105@redhat.com>
Date: Sat, 17 Oct 2009 09:48:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1255037747-3340-1-git-send-email-lcapitulino@redhat.com>	<1255037747-3340-2-git-send-email-lcapitulino@redhat.com>	<4AD72B88.2040107@codemonkey.ws>	<20091015122622.1f93ea2d@doriath>	<20091015163936.GB532@redhat.com>	<20091015142837.6c90580a@doriath>	<4AD76B3C.3050001@codemonkey.ws>	<4AD87424.3010000@redhat.com>	<4AD87901.5030705@codemonkey.ws>	<4AD8AECE.9000507@redhat.com>	<4AD8AFA4.4070203@codemonkey.ws>	<4AD8CB31.9080809@redhat.com>	<4AD8E7B5.8000509@codemonkey.ws>
	<4AD910BA.4090607@gnu.org> <4AD922EB.5030501@codemonkey.ws>
In-Reply-To: <4AD922EB.5030501@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 01/10] Introduce qmisc module
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <bonzini@gnu.org>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 10/17/2009 03:50 AM, Anthony Liguori wrote:
> Paolo Bonzini wrote:
>> On 10/16/2009 11:37 PM, Anthony Liguori wrote:
>>>
>>> I already am :-) Stay tuned, I should have a patch later this afternoon.
>>
>> Was it a race? (Seriously, sorry I didn't notice a couple of hours ago).
>>
>> This one is ~5% slower than the "Evil" one, but half the size. Tested
>> against the comments.json file from the "Evil" parser and with
>> valgrind too. Does all the funky Unicode stuff too.
>
> I haven't benchmarked mine. While yours came out an hour earlier, I
> included a full test suite, output QObjects, and support vararg parsing
> so I think I win :-)

Heh, Luiz and I had talked offlist and he'd take care of the rest 
(except the test suite) :-).

 > Having an explicit stack is unnecessary I think.

I'm curious to see yours now---the stack is used to detect things like 
[{"a":"b"},"c":"d"].  You could do that in the event handlers of course, 
but that kind of breaks the interface between the parser and event handlers.

Paolo