From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mz8vR-0002TC-HG
	for qemu-devel@nongnu.org; Sat, 17 Oct 2009 09:02:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mz8vK-0002Rn-BZ
	for qemu-devel@nongnu.org; Sat, 17 Oct 2009 09:02:22 -0400
Received: from [199.232.76.173] (port=37920 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mz8vI-0002RW-Ur
	for qemu-devel@nongnu.org; Sat, 17 Oct 2009 09:02:17 -0400
Received: from mail-qy0-f194.google.com ([209.85.221.194]:35815)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Mz8vI-0003X1-GA
	for qemu-devel@nongnu.org; Sat, 17 Oct 2009 09:02:16 -0400
Received: by qyk32 with SMTP id 32so1982068qyk.4
	for <qemu-devel@nongnu.org>; Sat, 17 Oct 2009 06:02:13 -0700 (PDT)
Message-ID: <4AD9C052.1020401@codemonkey.ws>
Date: Sat, 17 Oct 2009 08:02:10 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/7] forward declare all QObject subclasses
	in qobject.h
References: <1255766136-3028-1-git-send-email-pbonzini@redhat.com>
	<1255766136-3028-4-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1255766136-3028-4-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Paolo Bonzini wrote:
> This gives more freedom to define prototypes without dragging in
> the whole header files.
>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qobject.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/qobject.h b/qobject.h
> index 200644d..f5c78b2 100644
> --- a/qobject.h
> +++ b/qobject.h
> @@ -44,6 +44,10 @@ typedef enum {
>  } qtype_code;
>  
>  struct QObject;
> +struct QInt;
> +struct QString;
> +struct QDict;
> +struct QList;
>   

This seems like a layering violation to me.

Regards,

Anthony Liguori