From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MzqKl-0003WO-30
	for qemu-devel@nongnu.org; Mon, 19 Oct 2009 07:23:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MzqKg-0003U7-NL
	for qemu-devel@nongnu.org; Mon, 19 Oct 2009 07:23:26 -0400
Received: from [199.232.76.173] (port=53452 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MzqKg-0003Tx-DA
	for qemu-devel@nongnu.org; Mon, 19 Oct 2009 07:23:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27987)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1MzqKf-0003jw-Uu
	for qemu-devel@nongnu.org; Mon, 19 Oct 2009 07:23:22 -0400
Message-ID: <4ADC4C0E.2040408@redhat.com>
Date: Mon, 19 Oct 2009 13:22:54 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1255453026-18637-1-git-send-email-lcapitulino@redhat.com>	<1255453026-18637-8-git-send-email-lcapitulino@redhat.com>	<877huy6hzm.fsf@pike.pond.sub.org>	<20091019101241.GA27871@redhat.com>
	<4ADC4208.4060701@redhat.com>
In-Reply-To: <4ADC4208.4060701@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 7/9] qdev: Use QError for not found error
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: aliguori@us.ibm.com, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On 10/19/2009 12:40 PM, Gerd Hoffmann wrote:
>> 'could not open device: permission denied' 'could not open device:
>> no such file or directory' 'could not open device: device or
>> resource busy'
>
> Which makes me wonder whenever it makes sense to re-use errno for the
> error codes instead of inventing our own QERR_* codes?

The errno would be just one field in the error.  You'd have
QERR_COULD_NOT_OPEN with a string field EACCES/ENOENT/EBUSY/Ewhatever.

> Not the numbers of course because they are not standardized as far I
> know, but the Ename strings.

No, numbers are not standardized.

Paolo