From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MzyE5-0000by-Bd for qemu-devel@nongnu.org; Mon, 19 Oct 2009 15:49:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MzyE0-0000S7-G2 for qemu-devel@nongnu.org; Mon, 19 Oct 2009 15:49:04 -0400 Received: from [199.232.76.173] (port=43273 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MzyE0-0000R9-47 for qemu-devel@nongnu.org; Mon, 19 Oct 2009 15:49:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12968) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MzyDz-0007Kc-Ly for qemu-devel@nongnu.org; Mon, 19 Oct 2009 15:48:59 -0400 Message-ID: <4ADCC2A5.5030200@redhat.com> Date: Mon, 19 Oct 2009 21:48:53 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 8/9] Set default console to virtio on S390x References: <1255963059-10298-1-git-send-email-agraf@suse.de> <1255963059-10298-2-git-send-email-agraf@suse.de> <1255963059-10298-3-git-send-email-agraf@suse.de> <1255963059-10298-4-git-send-email-agraf@suse.de> <1255963059-10298-5-git-send-email-agraf@suse.de> <1255963059-10298-6-git-send-email-agraf@suse.de> <1255963059-10298-7-git-send-email-agraf@suse.de> <1255963059-10298-8-git-send-email-agraf@suse.de> <1255963059-10298-9-git-send-email-agraf@suse.de> In-Reply-To: <1255963059-10298-9-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Carsten Otte , qemu-devel , hare@suse.de On 10/19/09 16:37, Alexander Graf wrote: > All "normal" system emulation targets in qemu I'm aware of display output > on either VGA or serial output. > > Our S390x virtio machine doesn't have such kind of legacy hardware. So > instead we need to default to a virtio console. > > I'm not particularly proud of this patch. It would be a lot better to > have something in the machine description that tells us about the default > terminal. One more reason to move the default devices qemu creates to a (machine specific) config file ... cheers, Gerd