From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MzyYa-0001IA-G9
	for qemu-devel@nongnu.org; Mon, 19 Oct 2009 16:10:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MzyYV-00019E-IU
	for qemu-devel@nongnu.org; Mon, 19 Oct 2009 16:10:15 -0400
Received: from [199.232.76.173] (port=44522 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MzyYV-00018z-En
	for qemu-devel@nongnu.org; Mon, 19 Oct 2009 16:10:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10561)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MzyYU-0002j1-Vk
	for qemu-devel@nongnu.org; Mon, 19 Oct 2009 16:10:11 -0400
Message-ID: <4ADCC79D.70302@redhat.com>
Date: Mon, 19 Oct 2009 22:10:05 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/9] Add S390x virtio machine bus
References: <1255963059-10298-1-git-send-email-agraf@suse.de>	<1255963059-10298-2-git-send-email-agraf@suse.de>	<1255963059-10298-3-git-send-email-agraf@suse.de>	<1255963059-10298-4-git-send-email-agraf@suse.de>
	<1255963059-10298-5-git-send-email-agraf@suse.de>
	<4ADCBF44.7090401@redhat.com>
	<F10DA25C-AB43-4D10-8F3B-05540297000F@suse.de>
In-Reply-To: <F10DA25C-AB43-4D10-8F3B-05540297000F@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, hare@suse.de

   Hi,

>> Also I'd suggest to add a sysbus -> s390-virtio bus bridge device, so
>> your bus gets properly hooked up in the device tree. Have a look at
>> the (quite simple) "isabus-bridge" device in isa-bus.c, which is used
>> with 'qemu -M isapc'. You'll see the s390-virtio bus and all virtio
>> devices attached to it in 'info qtree' then.
>
> Uh, ok :o. Is that really important?

Quite a few things depend on it.  I think creating disks via '-device 
virtio-blk-s390' will not work without that ...

cheers,
   Gerd