From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0ACl-0008F7-Au
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 04:36:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0ACg-0008Dv-FI
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 04:36:30 -0400
Received: from [199.232.76.173] (port=54553 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0ACg-0008Ds-AK
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 04:36:26 -0400
Received: from mtagate6.de.ibm.com ([195.212.17.166]:37183)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <carsteno@de.ibm.com>) id 1N0ACf-0007xp-QR
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 04:36:26 -0400
Received: from d12nrmr1607.megacenter.de.ibm.com
	(d12nrmr1607.megacenter.de.ibm.com [9.149.167.49])
	by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id n9K8aNPA023091
	for <qemu-devel@nongnu.org>; Tue, 20 Oct 2009 08:36:23 GMT
Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com
	[9.149.165.229])
	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id n9K8aH4k2486344
	for <qemu-devel@nongnu.org>; Tue, 20 Oct 2009 10:36:23 +0200
Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1])
	by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id n9K8aHhr005811
	for <qemu-devel@nongnu.org>; Tue, 20 Oct 2009 10:36:17 +0200
Message-ID: <4ADD768B.5030606@de.ibm.com>
Date: Tue, 20 Oct 2009 10:36:27 +0200
From: Carsten Otte <carsteno@de.ibm.com>
MIME-Version: 1.0
References: <1255963059-10298-1-git-send-email-agraf@suse.de>
	<1255963059-10298-2-git-send-email-agraf@suse.de>
	<1255963059-10298-3-git-send-email-agraf@suse.de>
In-Reply-To: <1255963059-10298-3-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/9] Add KVM support for S390x
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, hare@suse.de

Alexander Graf wrote:
> ++static int s390_cpu_initial_reset(CPUState *env)
+{
+    /* XXX */
+    fprintf(stderr, "XXX SIGP init\n");
+    return -1;
+}
That one will really  break SMP. Most of the initial reset is handled 
in-kernel for your convenience, therefore please think about using Kuli 
as inspiration on how to do this one ;-).
Other then that, the s390 specifics in this patch look really nice.