From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0cCY-0000Er-Sp
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:30:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0cCT-00009O-W0
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:30:10 -0400
Received: from [199.232.76.173] (port=43201 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0cCT-000099-PX
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:30:05 -0400
Received: from mail-fx0-f211.google.com ([209.85.220.211]:58725)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1N0cCT-0005eP-EB
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:30:05 -0400
Received: by fxm7 with SMTP id 7so7401313fxm.34
	for <qemu-devel@nongnu.org>; Wed, 21 Oct 2009 07:30:01 -0700 (PDT)
Message-ID: <4ADF1AE4.8020004@codemonkey.ws>
Date: Wed, 21 Oct 2009 09:29:56 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram
	allocation
References: <1256117106-9475-1-git-send-email-agraf@suse.de>
	<1256117106-9475-2-git-send-email-agraf@suse.de>
In-Reply-To: <1256117106-9475-2-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

Alexander Graf wrote:
> S390 requires vmas for guests to be < 256 GB. So we need to directly export
> mmaps "try to use this vma as start address" feature to not accidently get
> over that limit.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  cpu-common.h |    1 +
>  exec.c       |   15 +++++++++++++--
>  2 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/cpu-common.h b/cpu-common.h
> index 6302372..ecaf9e3 100644
> --- a/cpu-common.h
> +++ b/cpu-common.h
> @@ -30,6 +30,7 @@ static inline void cpu_register_physical_memory(target_phys_addr_t start_addr,
>  
>  ram_addr_t cpu_get_physical_page_desc(target_phys_addr_t addr);
>  ram_addr_t qemu_ram_alloc(ram_addr_t);
> +ram_addr_t _qemu_ram_alloc(ram_addr_t size, void *map_at);
>   

I don't like this interface very much.  Couldn't the fact that we need a 
va starting at 0 for s390 kvm be hidden behind the existing qemu_ram_alloc?

Regards,

Anthony Liguori