From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0ce8-0004dT-8U
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:58:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0ce3-0004Yo-NG
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:58:39 -0400
Received: from [199.232.76.173] (port=50704 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0ce3-0004Yb-Cx
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:58:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26550)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1N0cXk-0001uZ-Qc
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:52:05 -0400
Message-ID: <4ADF2010.5060307@redhat.com>
Date: Wed, 21 Oct 2009 16:52:00 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] properly save kvm system time msr	registers
References: <1256047441-9846-1-git-send-email-glommer@redhat.com>
	<4ADF0ED7.8000706@redhat.com>
	<20091021143228.GD8092@mothafucka.localdomain>
In-Reply-To: <20091021143228.GD8092@mothafucka.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org

On 10/21/09 16:32, Glauber Costa wrote:
> On Wed, Oct 21, 2009 at 03:38:31PM +0200, Gerd Hoffmann wrote:
>> On 10/20/09 16:04, Glauber Costa wrote:
>>> Currently, the msrs involved in setting up pvclock are not saved over
>>> migration and/or save/restore. This patch puts their value in special
>>> fields in our CPUState, and deal with them using vmstate.
>>>
>>> kvm also has to account for it, by including them in the msr list
>>> for the ioctls.
>>
>> Fails to build.  Fedora 11 machine with distro kernel.
>>
>> http://repo.or.cz/w/qemu/pdb.git?a=blob;f=build.log;h=5b8a2e83116dc6a74e5045e30c3efe71fa7397ef;hb=0b4f913c89b89b45d3844dc1cf321e3d94871ecb
> strange message. Do we need --kerneldir for that?

Requiring --kerneldir for a successful build isn't going to fly.

> kvm_para.h should be available...

Nope:

    $ rpm -ql kernel-headers | grep kvm
    /usr/include/asm/kvm.h
    /usr/include/linux/kvm.h

Did you ever build this?
You should improve your patch qa ...

cheers,
   Gerd