From: Gerd Hoffmann <kraxel@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers
Date: Thu, 22 Oct 2009 10:00:37 +0200 [thread overview]
Message-ID: <4AE01125.3080501@redhat.com> (raw)
In-Reply-To: <20091021193950.GF8092@mothafucka.localdomain>
On 10/21/09 21:39, Glauber Costa wrote:
>> $ rpm -ql kernel-headers | grep kvm
>> /usr/include/asm/kvm.h
>> /usr/include/linux/kvm.h
>>
>> Did you ever build this?
>> You should improve your patch qa ...
> btw, it builds fine for me even without --kerneldir, just tested.
>
> and the<linux/kvm_para.h> include is there since Feb08, a while now.
Which doesn't imply "make headers" actually includes that file. Even
rawhide aka soon-to-be-F12 ships no kvm_para.h header file in
kernel-headers.
Just defining the msrs instead of using kvm_para.h should be fine, the
numbers will not change ...
cheers,
Gerd
next prev parent reply other threads:[~2009-10-22 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 14:04 [Qemu-devel] [PATCH] properly save kvm system time msr registers Glauber Costa
2009-10-21 13:38 ` Gerd Hoffmann
2009-10-21 14:32 ` Glauber Costa
2009-10-21 14:52 ` Gerd Hoffmann
2009-10-21 14:57 ` Glauber Costa
2009-10-21 19:39 ` Glauber Costa
2009-10-22 8:00 ` Gerd Hoffmann [this message]
2009-10-22 11:23 ` Glauber Costa
2009-10-22 12:15 ` Gerd Hoffmann
2009-10-22 12:21 ` Glauber Costa
2009-10-22 12:22 ` Glauber Costa
2009-10-22 14:08 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE01125.3080501@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).