From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0sbK-0004XW-Ng
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 04:00:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0sbE-0004Vq-9j
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 04:00:48 -0400
Received: from [199.232.76.173] (port=36674 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0sbD-0004Vl-RX
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 04:00:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17508)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1N0sbD-0003o6-8Q
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 04:00:43 -0400
Message-ID: <4AE01125.3080501@redhat.com>
Date: Thu, 22 Oct 2009 10:00:37 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers
References: <1256047441-9846-1-git-send-email-glommer@redhat.com>	<4ADF0ED7.8000706@redhat.com>	<20091021143228.GD8092@mothafucka.localdomain>	<4ADF2010.5060307@redhat.com>
	<20091021193950.GF8092@mothafucka.localdomain>
In-Reply-To: <20091021193950.GF8092@mothafucka.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org

On 10/21/09 21:39, Glauber Costa wrote:
>>     $ rpm -ql kernel-headers | grep kvm
>>     /usr/include/asm/kvm.h
>>     /usr/include/linux/kvm.h
>>
>> Did you ever build this?
>> You should improve your patch qa ...
> btw, it builds fine for me even without --kerneldir, just tested.
>
> and the<linux/kvm_para.h>  include is there since Feb08, a while now.

Which doesn't imply "make headers" actually includes that file.  Even 
rawhide aka soon-to-be-F12 ships no kvm_para.h header file in 
kernel-headers.

Just defining the msrs instead of using kvm_para.h should be fine, the 
numbers will not change ...

cheers,
   Gerd