From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0uvt-0006m1-Rv for qemu-devel@nongnu.org; Thu, 22 Oct 2009 06:30:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0uvp-0006jV-7E for qemu-devel@nongnu.org; Thu, 22 Oct 2009 06:30:13 -0400 Received: from [199.232.76.173] (port=58441 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0uvo-0006jL-W1 for qemu-devel@nongnu.org; Thu, 22 Oct 2009 06:30:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49980) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N0uvo-0002Vc-9x for qemu-devel@nongnu.org; Thu, 22 Oct 2009 06:30:08 -0400 Message-ID: <4AE03425.30603@redhat.com> Date: Thu, 22 Oct 2009 12:29:57 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1255963059-10298-1-git-send-email-agraf@suse.de> <4ADDE7E3.9090601@de.ibm.com> <4AE0210D.9020409@redhat.com> <4AE02379.4090603@de.ibm.com> <4AE02DA1.8090500@redhat.com> <4AE031D0.50002@de.ibm.com> In-Reply-To: <4AE031D0.50002@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/9] S390x KVM support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Carsten Otte Cc: Carsten Otte , KVM list , Alexander Graf , qemu-devel , hare@suse.de On 10/22/2009 12:20 PM, Carsten Otte wrote: > Avi Kivity wrote: >> gdb is hardly performance critical. Is that the only reason for the >> change? > Right, gdb is not performance critical. gdb is the reason for moving > it out of the union, performance is the reason for having it in > kvm_run at all. > There's only more reason to it: with a little tweaking in kuli, we'll > be able to get rid of KVM_S390_SET_INITIAL_PSW ioctl with this change. > That removes one oddity that makes us different from other platforms. In fact qemu/x86 does a KVM_SET_SREGS (which updates pc) on reset. -- error compiling committee.c: too many arguments to function