From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0wZY-0006yC-Hk
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 08:15:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0wZT-0006up-QU
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 08:15:15 -0400
Received: from [199.232.76.173] (port=34267 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0wZS-0006uO-Rk
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 08:15:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15765)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1N0wZS-0003Lw-G9
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 08:15:10 -0400
Message-ID: <4AE04CCA.7030300@redhat.com>
Date: Thu, 22 Oct 2009 14:15:06 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers
References: <1256047441-9846-1-git-send-email-glommer@redhat.com>	<4ADF0ED7.8000706@redhat.com>	<20091021143228.GD8092@mothafucka.localdomain>	<4ADF2010.5060307@redhat.com>	<20091021193950.GF8092@mothafucka.localdomain>	<4AE01125.3080501@redhat.com>
	<20091022112327.GG8092@mothafucka.localdomain>
In-Reply-To: <20091022112327.GG8092@mothafucka.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org

>> Just defining the msrs instead of using kvm_para.h should be fine, the
>> numbers will not change ...
> That's not the problem. If one removes kvm_para.h, a lot of other things
> will not build. For example, the capabilities list.
> And it has been like this for almost a year now!
>
> Without that header, your system should have never successfully built a
> qemu-kvm instance. This is what happens here, if I try to remove it:

qemu != qemu-kvm.

qemu-kvm ships with a copy of the kvm kernel header files.
upstream qemu doesn't.

cheers,
   Gerd