From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0yLy-0007RD-GC for qemu-devel@nongnu.org; Thu, 22 Oct 2009 10:09:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0yLu-0007QX-Sw for qemu-devel@nongnu.org; Thu, 22 Oct 2009 10:09:22 -0400 Received: from [199.232.76.173] (port=42993 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0yLu-0007QP-Ov for qemu-devel@nongnu.org; Thu, 22 Oct 2009 10:09:18 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:46411) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N0yLu-0003u7-Aa for qemu-devel@nongnu.org; Thu, 22 Oct 2009 10:09:18 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e38.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n9ME4sQc010507 for ; Thu, 22 Oct 2009 08:04:54 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9ME8xnx087204 for ; Thu, 22 Oct 2009 08:09:00 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n9ME8xrn006820 for ; Thu, 22 Oct 2009 08:08:59 -0600 Message-ID: <4AE06771.4050502@us.ibm.com> Date: Thu, 22 Oct 2009 09:08:49 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers References: <1256047441-9846-1-git-send-email-glommer@redhat.com> <4ADF0ED7.8000706@redhat.com> <20091021143228.GD8092@mothafucka.localdomain> <4ADF2010.5060307@redhat.com> <20091021193950.GF8092@mothafucka.localdomain> <4AE01125.3080501@redhat.com> <20091022112327.GG8092@mothafucka.localdomain> In-Reply-To: <20091022112327.GG8092@mothafucka.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Marcelo Tosatti , Gerd Hoffmann , qemu-devel@nongnu.org Glauber Costa wrote: > That's not the problem. If one removes kvm_para.h, a lot of other thing= s > will not build. For example, the capabilities list. > And it has been like this for almost a year now! > > Without that header, your system should have never successfully built a > qemu-kvm instance. This is what happens here, if I try to remove it: > > error: =E2=80=98KVM_FEATURE_CLOCKSOURCE=E2=80=99 undeclared here (not = in a function) > error: =E2=80=98KVM_FEATURE_NOP_IO_DELAY=E2=80=99 undeclared here (not= in a function) > error: =E2=80=98KVM_FEATURE_MMU_OP=E2=80=99 undeclared here (not in a = function) > > So again, wth? > =20 FWIW, I always build with --kerneldir. I'd like to pull in KVM headers=20 but every time we discuss it it seems to rat hole. --=20 Regards, Anthony Liguori