From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N10tH-00071K-9h for qemu-devel@nongnu.org; Thu, 22 Oct 2009 12:51:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N10tC-0006vL-K6 for qemu-devel@nongnu.org; Thu, 22 Oct 2009 12:51:54 -0400 Received: from [199.232.76.173] (port=54131 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N10tC-0006v6-Ey for qemu-devel@nongnu.org; Thu, 22 Oct 2009 12:51:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64594) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N10tB-00048s-Vx for qemu-devel@nongnu.org; Thu, 22 Oct 2009 12:51:50 -0400 Message-ID: <4AE08DA2.7040203@redhat.com> Date: Thu, 22 Oct 2009 18:51:46 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] test for lm capable kernel. References: <1255540160-19869-1-git-send-email-glommer@redhat.com> In-Reply-To: <1255540160-19869-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 10/14/2009 07:09 PM, Glauber Costa wrote: > Don't save x86_64-specific msrs if our kernel does not support them. > Code is already in qemu-kvm.git, but the test function is slightly different. > It follows what the test for msr_start does. > Can't we use KVM_GET_MSR_LIST to see which msrs are supported instead? -- error compiling committee.c: too many arguments to function