From: Anthony Liguori <anthony@codemonkey.ws>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] CODING_STYLE and if blocks
Date: Thu, 22 Oct 2009 17:42:00 -0500 [thread overview]
Message-ID: <4AE0DFB8.2070804@codemonkey.ws> (raw)
In-Reply-To: <20091022220153.GB10700@volta.aurel32.net>
Aurelien Jarno wrote:
> Hi all,
>
> I am currently reviewing the S390 patches which extensively use of
> code like:
>
> if (a == 5) printf("a was 5.\n");
> else if (a == 6) printf("a was 6.\n");
> else printf("a was something else entirely.\n");
>
> It is something currently allowed by the CODING_STYLE document (there is
> no "indented statement"), but I am not fully comfortable with it. Should
> we accept such code? Should we fix CODING_STYLE?
>
I'd vote for fixing CODING_STYLE as that syntax makes my eyes hurt.
While CODING_STYLE is there as a guideline, good taste should still
always prevail :-)
Regards,
Anthony Liguori
> Cheers,
> Aurelien
>
>
next prev parent reply other threads:[~2009-10-22 22:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 22:01 [Qemu-devel] CODING_STYLE and if blocks Aurelien Jarno
2009-10-22 22:42 ` Anthony Liguori [this message]
2009-10-22 23:47 ` Alexander Graf
2009-10-23 6:55 ` Aurelien Jarno
2009-10-22 22:49 ` [Qemu-devel] " Måns Rullgård
2009-10-22 23:10 ` [Qemu-devel] " Natalia Portillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE0DFB8.2070804@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).