From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N16MF-0006qX-Qw
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 18:42:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N16MB-0006nu-C0
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 18:42:11 -0400
Received: from [199.232.76.173] (port=43048 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N16MB-0006nl-8U
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 18:42:07 -0400
Received: from mail-ew0-f211.google.com ([209.85.219.211]:40078)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1N16MA-000766-UK
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 18:42:07 -0400
Received: by ewy7 with SMTP id 7so7748000ewy.34
	for <qemu-devel@nongnu.org>; Thu, 22 Oct 2009 15:42:06 -0700 (PDT)
Message-ID: <4AE0DFB8.2070804@codemonkey.ws>
Date: Thu, 22 Oct 2009 17:42:00 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] CODING_STYLE and if blocks
References: <20091022220153.GB10700@volta.aurel32.net>
In-Reply-To: <20091022220153.GB10700@volta.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

Aurelien Jarno wrote:
> Hi all,
>
> I am currently reviewing the S390 patches which extensively use of
> code like:
>
>     if (a == 5) printf("a was 5.\n");
>     else if (a == 6) printf("a was 6.\n");
>     else printf("a was something else entirely.\n");
>
> It is something currently allowed by the CODING_STYLE document (there is
> no "indented statement"), but I am not fully comfortable with it. Should
> we accept such code? Should we fix CODING_STYLE?
>   

I'd vote for fixing CODING_STYLE as that syntax makes my eyes hurt.

While CODING_STYLE is there as a guideline, good taste should still 
always prevail :-)

Regards,

Anthony Liguori

> Cheers,
> Aurelien
>
>