From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2KBm-0001gr-Sf for qemu-devel@nongnu.org; Mon, 26 Oct 2009 03:40:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2KBg-0001ZU-3T for qemu-devel@nongnu.org; Mon, 26 Oct 2009 03:40:24 -0400 Received: from [199.232.76.173] (port=39803 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2KBf-0001ZM-T9 for qemu-devel@nongnu.org; Mon, 26 Oct 2009 03:40:19 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:42462) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N2KBf-0006CO-5l for qemu-devel@nongnu.org; Mon, 26 Oct 2009 03:40:19 -0400 Message-ID: <4AE5525C.2040301@web.de> Date: Mon, 26 Oct 2009 08:40:12 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened References: <1254920477-4645-1-git-send-email-amit.shah@redhat.com> <1254920477-4645-2-git-send-email-amit.shah@redhat.com> <1254920477-4645-3-git-send-email-amit.shah@redhat.com> <1254920477-4645-4-git-send-email-amit.shah@redhat.com> <4AE2D8C6.7070802@web.de> <20091026035312.GB11416@amit-x200.redhat.com> In-Reply-To: <20091026035312.GB11416@amit-x200.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEDB4B40C188E9BAADF122D3B" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEDB4B40C188E9BAADF122D3B Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Amit Shah wrote: > On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote: >> Amit Shah wrote: >>> The OPENED event gets sent also when qemu resets its state initially.= >>> The consumers of the event aren't interested in receiving this event >>> on reset. >> The monitor was. Now its initial prompt on activation is broken. >=20 > The patch in Anthony's queue, titled >=20 > 'console: call qemu_chr_reset() in text_console_init' You may also want to rename qemu_chr_reset - unless there is still a need for real "reset". >=20 > fixed that. >=20 > However, with the qcow2 synchronous patch, the monitor prompt doesn't > come up again -- which shows there is a problem with the way the bhs > work and also the initial resets. Then the qcow2 patch is already in? At least applying your patch doesn't change the picture. >=20 > I think the initial resets are a hack to work around something from my > reading of it; do you have a better idea of why it's there and how it's= > all supposed to work? =46rom the monitor's POV, it's not a hack, it's simply the requirement to= receive an indication that the console was opened. >=20 >> Does this patch fix/improve something for a different user? If not, >> please let us revert it. >=20 > There's another question too: is a separate 'reset' event needed in > addition to an 'opened' event? Not for the monitor, but I cannot speak for other users. I think it would be good to check them in details before changing the reset/open semantic. >=20 > I have a few apps (that are coming as part of the virtio-console work) > that need just an 'opened' event and are not interested in the 'reset' > event. >=20 > Amit Jan --------------enigEDB4B40C188E9BAADF122D3B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkrlUmAACgkQitSsb3rl5xR6/QCcCbTsniDWZ/qabihfaT2fIGNg WN0AoMDSHqebY9xFyeBWpG38Nx07ROH+ =6HG/ -----END PGP SIGNATURE----- --------------enigEDB4B40C188E9BAADF122D3B--