From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2Le6-0002kA-No for qemu-devel@nongnu.org; Mon, 26 Oct 2009 05:13:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2Le2-0002it-41 for qemu-devel@nongnu.org; Mon, 26 Oct 2009 05:13:46 -0400 Received: from [199.232.76.173] (port=41689 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2Le1-0002ik-P3 for qemu-devel@nongnu.org; Mon, 26 Oct 2009 05:13:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60546) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N2Le1-0002Ba-DA for qemu-devel@nongnu.org; Mon, 26 Oct 2009 05:13:41 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9Q9DaVv023492 for ; Mon, 26 Oct 2009 05:13:37 -0400 Message-ID: <4AE5683E.1020907@redhat.com> Date: Mon, 26 Oct 2009 10:13:34 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] isa: configure serial+parallel by index. References: <1255433919-25736-1-git-send-email-kraxel@redhat.com> <87zl7v9koc.fsf@pike.pond.sub.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org >> Looks fine to me. A similar solution could do for default mac address. > > One little thing I missed on first reading: making an index property > hexadecimal is weird. I'd really expect decimal there. Indeed. Wasn't intentional, cut+paste bug. Will fix. cheers, Gerd