From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2WvO-0006c0-Rm for qemu-devel@nongnu.org; Mon, 26 Oct 2009 17:16:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2WvJ-0006YP-Ht for qemu-devel@nongnu.org; Mon, 26 Oct 2009 17:16:22 -0400 Received: from [199.232.76.173] (port=38701 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2WvJ-0006YK-DM for qemu-devel@nongnu.org; Mon, 26 Oct 2009 17:16:17 -0400 Received: from mail-qy0-f194.google.com ([209.85.221.194]:63238) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N2WvJ-00026b-1R for qemu-devel@nongnu.org; Mon, 26 Oct 2009 17:16:17 -0400 Received: by qyk32 with SMTP id 32so6864790qyk.4 for ; Mon, 26 Oct 2009 14:16:16 -0700 (PDT) Message-ID: <4AE6119C.8040008@codemonkey.ws> Date: Mon, 26 Oct 2009 16:16:12 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: don't allow non-indented statements after if/else blocks References: <20091026062637.GA21562@volta.aurel32.net> <20091026200326.GA9669@volta.aurel32.net> <20091026202707.GR26129@hall.aurel32.net> In-Reply-To: <20091026202707.GR26129@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Blue Swirl , qemu-devel@nongnu.org Aurelien Jarno wrote: > That's the problem. We have seen that people already take advantage of > the ambiguities, as I would have never have imagined someone writing the > code in the rationale of this patch to avoid putting braces. > I appreciate the desire to be precise, but we aren't writing a compiler or an automated syntax checker. We're writing a set of guidelines for reasonable people to follow. If someone sets out to "defeat" CODING_STYLE by introducing some crazy syntax, the solution is simple--just don't take the patch. Good sense must prevail regardless of what CODING_STYLE says. Regards, Anthony Liguori