From: Kevin Wolf <kwolf@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Amit Shah <amit.shah@redhat.com>, Jan Kiszka <jan.kiszka@web.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened
Date: Tue, 27 Oct 2009 15:22:06 +0100 [thread overview]
Message-ID: <4AE7020E.4000300@redhat.com> (raw)
In-Reply-To: <4AE6FE02.7000802@us.ibm.com>
Am 27.10.2009 15:04, schrieb Anthony Liguori:
> Amit Shah wrote:
>> On (Tue) Oct 27 2009 [09:40:27], Kevin Wolf wrote:
>>
>>>> All that said, I'm ok with reverting that patch now till I find some
>>>> kind of a solution to this.
>>>>
>>> Which patch do you want to revert? You're aware that the qcow2 patch is
>>> a data corruption fix?
>>>
>>
>> Ah, no. Reverting my patch that causes this problem. I know the qcow2
>> patch only exposes the bh handling issue. I intend to fix that
>> appropriately elsewhere :-)
>>
>
> How does Kevin's latest patches that introduces new BHs semantics affect
> all of this?
I'd expect that it will make the bug visible it in the very same way as
the qcow2 workaround currently does. In both cases we don't run BHs that
the monitor/char code relies on to be run early.
Kevin
prev parent reply other threads:[~2009-10-27 14:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 13:01 [Qemu-devel] [PATCH v2 0/3] Send out OPENED events only on chardev open Amit Shah
2009-10-07 13:01 ` [Qemu-devel] [PATCH v2 1/3] char: check for initial_reset_issued unnecessary Amit Shah
2009-10-07 13:01 ` [Qemu-devel] [PATCH v2 2/3] char: rename CHR_EVENT_RESET to CHR_EVENT_OPENED Amit Shah
2009-10-07 13:01 ` [Qemu-devel] [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened Amit Shah
2009-10-24 10:36 ` [Qemu-devel] " Jan Kiszka
2009-10-26 3:53 ` Amit Shah
2009-10-26 7:40 ` Jan Kiszka
2009-10-26 9:28 ` Amit Shah
2009-10-26 20:15 ` Jan Kiszka
2009-10-27 7:46 ` Amit Shah
2009-10-27 8:40 ` Kevin Wolf
2009-10-27 9:20 ` Amit Shah
2009-10-27 14:04 ` Anthony Liguori
2009-10-27 14:14 ` Amit Shah
2009-10-27 14:22 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE7020E.4000300@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=amit.shah@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).