From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N2mxE-0000bo-Sz
	for qemu-devel@nongnu.org; Tue, 27 Oct 2009 10:23:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N2mxA-0000au-4W
	for qemu-devel@nongnu.org; Tue, 27 Oct 2009 10:23:20 -0400
Received: from [199.232.76.173] (port=46382 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N2mx9-0000aq-U6
	for qemu-devel@nongnu.org; Tue, 27 Oct 2009 10:23:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65521)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1N2mx9-0006Up-0V
	for qemu-devel@nongnu.org; Tue, 27 Oct 2009 10:23:15 -0400
Message-ID: <4AE7020E.4000300@redhat.com>
Date: Tue, 27 Oct 2009 15:22:06 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event	only
	when a new char connection is opened
References: <1254920477-4645-2-git-send-email-amit.shah@redhat.com>
	<1254920477-4645-3-git-send-email-amit.shah@redhat.com>
	<1254920477-4645-4-git-send-email-amit.shah@redhat.com>
	<4AE2D8C6.7070802@web.de>	<20091026035312.GB11416@amit-x200.redhat.com>
	<4AE5525C.2040301@web.de>	<20091026092841.GE11416@amit-x200.redhat.com>
	<4AE6037D.4070100@web.de>	<20091027074615.GA28426@amit-x200.redhat.com>
	<4AE6B1FB.6040609@redhat.com>
	<20091027092033.GA3759@amit-x200.redhat.com>
	<4AE6FE02.7000802@us.ibm.com>
In-Reply-To: <4AE6FE02.7000802@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Amit Shah <amit.shah@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org

Am 27.10.2009 15:04, schrieb Anthony Liguori:
> Amit Shah wrote:
>> On (Tue) Oct 27 2009 [09:40:27], Kevin Wolf wrote:
>>   
>>>> All that said, I'm ok with reverting that patch now till I find some
>>>> kind of a solution to this.
>>>>       
>>> Which patch do you want to revert? You're aware that the qcow2 patch is
>>> a data corruption fix?
>>>     
>>
>> Ah, no. Reverting my patch that causes this problem. I know the qcow2
>> patch only exposes the bh handling issue. I intend to fix that
>> appropriately elsewhere :-)
>>   
> 
> How does Kevin's latest patches that introduces new BHs semantics affect 
> all of this?

I'd expect that it will make the bug visible it in the very same way as
the qcow2 workaround currently does. In both cases we don't run BHs that
the monitor/char code relies on to be run early.

Kevin