From: Paolo Bonzini <pbonzini@redhat.com>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 07/10] ac97: sizeof returns unsigned long
Date: Wed, 28 Oct 2009 16:50:31 +0100 [thread overview]
Message-ID: <4AE86847.3050604@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0910281839300.2101@linmac.oyster.ru>
On 10/28/2009 04:41 PM, malc wrote:
>>> > > sizeof returns size_t (%zX), so this is wrong
>> >
>> > size_t is long on all practical platforms except ia64-hpux and Win64, so this
>> > is not more wrong than it was before.
> Yea right, except that's it's not long on any 32bit platform, at least not
> from gcc's -Wformat point of view.
Still an improvement (wrong code vs. warning)... you are a committer,
you can fix it yourself if it bothers you...
Paolo
next prev parent reply other threads:[~2009-10-28 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 12:29 [Qemu-devel] [PATCH v2 00/10] Port audio to vmstate Juan Quintela
2009-10-28 12:29 ` [Qemu-devel] [PATCH 01/10] audio: fix compilation of DEBUG_PLIVE Juan Quintela
2009-10-28 12:29 ` [Qemu-devel] [PATCH 02/10] audio: port to vmstate Juan Quintela
2009-10-28 12:29 ` [Qemu-devel] [PATCH 03/10] sb16: " Juan Quintela
2009-10-28 12:29 ` [Qemu-devel] [PATCH 04/10] es1370: " Juan Quintela
2009-10-28 12:29 ` [Qemu-devel] [PATCH 05/10] c4231a: " Juan Quintela
2009-10-28 12:29 ` [Qemu-devel] [PATCH 06/10] gus: " Juan Quintela
2009-10-28 12:29 ` [Qemu-devel] [PATCH 07/10] ac97: sizeof returns unsigned long Juan Quintela
2009-10-28 12:53 ` [Qemu-devel] " malc
2009-10-28 13:11 ` Paolo Bonzini
2009-10-28 15:41 ` malc
2009-10-28 15:50 ` Paolo Bonzini [this message]
2009-10-28 16:25 ` malc
2009-10-28 12:29 ` [Qemu-devel] [PATCH 08/10] ac97: recalculate active after loadvm Juan Quintela
2009-10-28 12:29 ` [Qemu-devel] [PATCH 09/10] ac97: up savevm version and remove active from state Juan Quintela
2009-10-28 12:29 ` [Qemu-devel] [PATCH 10/10] ac97: port to vmstate Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE86847.3050604@redhat.com \
--to=pbonzini@redhat.com \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).