From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N3AnR-0006VW-2F
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 11:50:49 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N3AnK-0006L8-NV
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 11:50:46 -0400
Received: from [199.232.76.173] (port=39132 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N3AnK-0006Ke-4k
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 11:50:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23013)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1N3AnJ-0007ua-LY
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 11:50:41 -0400
Message-ID: <4AE86847.3050604@redhat.com>
Date: Wed, 28 Oct 2009 16:50:31 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 07/10] ac97: sizeof returns unsigned long
References: <cover.1256731509.git.quintela@redhat.com>
	<e328160589068e08ae5b6700bbd96567b80cd475.1256731509.git.quintela@redhat.com>
	<Pine.LNX.4.64.0910281552510.5319@linmac.oyster.ru>
	<hc9fuh$rl3$1@ger.gmane.org>
	<Pine.LNX.4.64.0910281839300.2101@linmac.oyster.ru>
In-Reply-To: <Pine.LNX.4.64.0910281839300.2101@linmac.oyster.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org

On 10/28/2009 04:41 PM, malc wrote:
>>> >  >  sizeof returns size_t (%zX), so this is wrong
>> >
>> >  size_t is long on all practical platforms except ia64-hpux and Win64, so this
>> >  is not more wrong than it was before.
> Yea right, except that's it's not long on any 32bit platform, at least not
> from gcc's -Wformat point of view.

Still an improvement (wrong code vs. warning)...  you are a committer, 
you can fix it yourself if it bothers you...

Paolo