From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3W9F-0007IZ-6M for qemu-devel@nongnu.org; Thu, 29 Oct 2009 10:38:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3W9A-0007G5-G6 for qemu-devel@nongnu.org; Thu, 29 Oct 2009 10:38:44 -0400 Received: from [199.232.76.173] (port=57696 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3W99-0007Fm-WE for qemu-devel@nongnu.org; Thu, 29 Oct 2009 10:38:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47606) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3W98-0006ot-IY for qemu-devel@nongnu.org; Thu, 29 Oct 2009 10:38:39 -0400 Message-ID: <4AE9A8DE.1070609@redhat.com> Date: Thu, 29 Oct 2009 16:38:22 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1256807803.10825.39.camel@blaa> <20091029122334.GB3478@redhat.com> In-Reply-To: <20091029122334.GB3478@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Mark McLoughlin , Scott Tsai , kvm@vger.kernel.org, Dustin Kirkland , qemu-devel@nongnu.org On 10/29/2009 02:23 PM, Michael S. Tsirkin wrote: > On Thu, Oct 29, 2009 at 09:16:43AM +0000, Mark McLoughlin wrote: > >> I agree we shouldn't exit in this scenario >> > virtio in qemu generally seems to handle guest errors > by calling exit(2). This probably makes it easier to notice > the problems, but is likely not the right thing to do. > Right, the thinking was the guest is shooting itself in the foot and hitting, but a guest can delegate control of a device to unprivileged code (for example device assignment in kvm), which would allow this unprivileged code to kill the guest. -- error compiling committee.c: too many arguments to function