From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3dAl-0000IN-SJ for qemu-devel@nongnu.org; Thu, 29 Oct 2009 18:08:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3dAh-0000Hn-DE for qemu-devel@nongnu.org; Thu, 29 Oct 2009 18:08:47 -0400 Received: from [199.232.76.173] (port=55610 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3dAh-0000Hk-9X for qemu-devel@nongnu.org; Thu, 29 Oct 2009 18:08:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3303) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3dAg-0005BF-NQ for qemu-devel@nongnu.org; Thu, 29 Oct 2009 18:08:43 -0400 Message-ID: <4AEA125C.5040203@redhat.com> Date: Thu, 29 Oct 2009 23:08:28 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1256841750-15228-1-git-send-email-lcapitulino@redhat.com> <1256841750-15228-3-git-send-email-lcapitulino@redhat.com> <4AE9F794.4030204@us.ibm.com> <20091029184834.4d6dd8a6@doriath> In-Reply-To: <20091029184834.4d6dd8a6@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/7] Introduce QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , hollisb@linux.vnet.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com On 10/29/2009 09:48 PM, Luiz Capitulino wrote: > > va_list doesn't need to be a pointer. > > Ok, but if this is going to be a public interface, I think it's > better to va_copy() before passing it to qobject_from_json_va() then. It is standard to pass a va_list by value without doing va_copy in the caller. >> > Shouldn't this take a ... too? > The problem is that its caller (qemu_error_structed()) also takes > a ..., I don't know how to pass the arguments to a second function with > variadic arguments w/o passing the va_list. Yeah, this is fine. Paolo