From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3uQh-0003O7-IL for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:34:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3uQd-0003MO-Rn for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:34:23 -0400 Received: from [199.232.76.173] (port=55205 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3uQd-0003MD-L2 for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:34:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1713) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3uQb-0006yd-VD for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:34:18 -0400 Message-ID: <4AEB1584.3070000@redhat.com> Date: Fri, 30 Oct 2009 17:34:12 +0100 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [RFC 0/7] QError v1 References: <1256841750-15228-1-git-send-email-lcapitulino@redhat.com> <4AEA133A.8010906@redhat.com> <20091030102809.1c520282@doriath> <4AEAE261.5030908@redhat.com> <4AEAE56E.8040309@us.ibm.com> <20091030162849.GH3579@shareable.org> In-Reply-To: <20091030162849.GH3579@shareable.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jamie Lokier Cc: qemu-devel@nongnu.org, Anthony Liguori , Luiz Capitulino , Gerd Hoffmann , hollisb@linux.vnet.ibm.com On 10/30/2009 05:28 PM, Jamie Lokier wrote: > By the way, since you've already invented a non-standard JSON > extension, which is the single quotes, why not go a step further and > permit the quotes to be omitted for simple tokens? > > #define QERR_DEV_NFOUND "{ code: 404, name: %s}" > > Much neater, IMHO. While I agree about the neatness, this is quite a slippery slope. If the macro tricks are going to confine the JSON templates in a header file, I don't see the need to extend the JSON parser further. Paolo