From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N4b3v-0003MA-7X
	for qemu-devel@nongnu.org; Sun, 01 Nov 2009 09:05:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N4b3q-0003Jf-82
	for qemu-devel@nongnu.org; Sun, 01 Nov 2009 09:05:42 -0500
Received: from [199.232.76.173] (port=40010 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N4b3q-0003Jc-1X
	for qemu-devel@nongnu.org; Sun, 01 Nov 2009 09:05:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:24179)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1N4b3p-0003EZ-CZ
	for qemu-devel@nongnu.org; Sun, 01 Nov 2009 09:05:37 -0500
Message-ID: <4AED95AC.8030900@redhat.com>
Date: Sun, 01 Nov 2009 16:05:32 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] e1000 fix: read access to some registers
	is	missing.
References: <172731552.20091031182943@uni-ulm.de>
In-Reply-To: <172731552.20091031182943@uni-ulm.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kay Ackermann <kay.ackermann@uni-ulm.de>
Cc: qemu-devel@nongnu.org

On 10/31/2009 07:29 PM, Kay Ackermann wrote:
>
> While writing working on an e1000 driver for my university's OS I
>
> noticed that some registers aren't readable in QEMU, but they should
>
> be readable as stated in Intels Driver Developer Manual (and also
>
> verified on real hardware).
>
>
>
> diff --git a/hw/e1000.c b/hw/e1000.c
>
> index 028afd1..3987e70 100644
>
> --- a/hw/e1000.c
>
> +++ b/hw/e1000.c
>
> @@ -789,6 +789,8 @@ static uint32_t (*macreg_readops[])(E1000State *, 
> int) = {
>
>      getreg(MANC),        getreg(MDIC),        getreg(SWSM),       
>  getreg(STATUS),
>
>      getreg(TORL),        getreg(TOTL),        getreg(IMS),       
>  getreg(TCTL),
>
>      getreg(RDH),        getreg(RDT),        getreg(VET),       
>  getreg(ICS),
>
> +    getreg(TDBAL),        getreg(TDBAH),        getreg(RDBAH),       
>  getreg(RDBAL),
>
> +    getreg(TDLEN),        getreg(RDLEN),
>
>      [TOTH] = mac_read_clr8,        [TORH] = mac_read_clr8,       
>  [GPRC] = mac_read_clr4,
>
>      [GPTC] = mac_read_clr4,        [TPR] = mac_read_clr4,       
>  [TPT] = mac_read_clr4,
>
>
>
>
> Oh and is there any specific reason why Jumbo-Frames are limited to 4k 
> instead of i.e. Alteon 9014 bytes?
>
>
>

There used to be a 4K buffer somewhere in the path.  I think it's larger 
now.

-- 
error compiling committee.c: too many arguments to function