From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N5mmP-0006TT-Qr
	for qemu-devel@nongnu.org; Wed, 04 Nov 2009 15:48:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N5mmL-0006Qy-3U
	for qemu-devel@nongnu.org; Wed, 04 Nov 2009 15:48:32 -0500
Received: from [199.232.76.173] (port=51703 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N5mmK-0006Qr-On
	for qemu-devel@nongnu.org; Wed, 04 Nov 2009 15:48:28 -0500
Received: from moutng.kundenserver.de ([212.227.17.9]:65507)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1N5mmK-0004kz-5n
	for qemu-devel@nongnu.org; Wed, 04 Nov 2009 15:48:28 -0500
Message-ID: <4AF1E896.4060606@mail.berlios.de>
Date: Wed, 04 Nov 2009 21:48:22 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix a parallel build failure.
References: <1257366009-7057-1-git-send-email-drow@false.org>
In-Reply-To: <1257366009-7057-1-git-send-email-drow@false.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Daniel Jacobowitz <dan@codesourcery.com>
Cc: qemu-devel@nongnu.org

Daniel Jacobowitz schrieb:
> From: Daniel Jacobowitz <dan@codesourcery.com>
>
> With enough parallelism, make will run all the dependencies of
> build-all at the same time:
>
> build-all: config-host.h config-all-devices.h $(DOCS) $(TOOLS)
>
> So some of the $(TOOLS) will build before config-host.h is finished.
> The object files need to depend on it explicitly.  Subdirectories are
> OK since they are started from the body of build-all, not its
> dependencies.
>
> Signed-off-by: Daniel Jacobowitz <dan@codesourcery.com>
> ---
>  Makefile  |    2 ++
>  rules.mak |    2 +-
>  2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index c783aa4..ed9a420 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,5 +1,7 @@
>  # Makefile for QEMU.
>  
> +GENERATED_HEADERS = config-host.h config-all-devices.h
> +
>  ifneq ($(wildcard config-host.mak),)
>  # Put the all: rule here so that config-host.mak can contain dependencies.
>  all: build-all
> diff --git a/rules.mak b/rules.mak
> index 5d7e8bb..4eb1f90 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -13,7 +13,7 @@ MAKEFLAGS += -rR
>  
>  QEMU_CFLAGS += -MMD -MP -MT $@
>  
> -%.o: %.c
> +%.o: %.c $(GENERATED_HEADERS)
>  	$(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
>  
>  %.o: %.S
>   

Maybe a mix of your patch and my patch
(http://patchwork.ozlabs.org/patch/37446/)
would be the best fix for this problem.

It should also be possible to apply both patches.

Regards
Stefan