From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N63bT-0001gM-3P
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:46:23 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N63bO-0001de-CS
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:46:22 -0500
Received: from [199.232.76.173] (port=52707 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N63bO-0001dZ-0S
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:46:18 -0500
Received: from e39.co.us.ibm.com ([32.97.110.160]:48966)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1N63bN-00006L-It
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:46:17 -0500
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com
	[9.17.195.106])
	by e39.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id nA5Ee6PJ026536
	for <qemu-devel@nongnu.org>; Thu, 5 Nov 2009 07:40:06 -0700
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	nA5Ejnuf132534
	for <qemu-devel@nongnu.org>; Thu, 5 Nov 2009 07:45:50 -0700
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1])
	by d03av01.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP
	id nA5EjlaX013822
	for <qemu-devel@nongnu.org>; Thu, 5 Nov 2009 07:45:48 -0700
Message-ID: <4AF2E519.8030808@us.ibm.com>
Date: Thu, 05 Nov 2009 08:45:45 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/4] Add support for -net bridge
References: <1257294485-27015-1-git-send-email-aliguori@us.ibm.com>
	<1257294485-27015-5-git-send-email-aliguori@us.ibm.com>
	<4AF2E407.9000809@redhat.com>
In-Reply-To: <4AF2E407.9000809@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, Arnd Bergmann <arndbergmann@googlemail.com>, Dustin Kirkland <kirkland@canonical.com>, Michael Tsirkin <mst@redhat.com>, Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org

Avi Kivity wrote:
>> +int net_init_bridge(QemuOpts *opts, Monitor *mon, const char *name, 
>> VLANState *vlan);
>> +
>>    
>
> Don't we need to tear the interface down after shutdown?

net_init_bridge calls net_tap_fd_init which registers tap_cleanup.  That 
closes the fd and frees associated memory.

The helper does not allocate a persistent tap device so closing the file 
descriptor is sufficient for cleanup.

-- 
Regards,

Anthony Liguori