From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N63eu-0003CZ-9v for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:49:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N63ep-00039m-Ng for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:49:55 -0500 Received: from [199.232.76.173] (port=50631 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N63ep-00039f-I0 for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:49:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28434) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N63eo-0000my-Vu for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:49:51 -0500 Message-ID: <4AF2E608.7000105@redhat.com> Date: Thu, 05 Nov 2009 16:49:44 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4/4] Add support for -net bridge References: <1257294485-27015-1-git-send-email-aliguori@us.ibm.com> <1257294485-27015-5-git-send-email-aliguori@us.ibm.com> <4AF2E407.9000809@redhat.com> <4AF2E519.8030808@us.ibm.com> In-Reply-To: <4AF2E519.8030808@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , Arnd Bergmann , Dustin Kirkland , Michael Tsirkin , Juan Quintela , qemu-devel@nongnu.org On 11/05/2009 04:45 PM, Anthony Liguori wrote: > Avi Kivity wrote: >>> +int net_init_bridge(QemuOpts *opts, Monitor *mon, const char *name, >>> VLANState *vlan); >>> + >> >> Don't we need to tear the interface down after shutdown? > > net_init_bridge calls net_tap_fd_init which registers tap_cleanup. > That closes the fd and frees associated memory. > > The helper does not allocate a persistent tap device so closing the > file descriptor is sufficient for cleanup. > Ah, so unclean shutdown will clean up as well. -- error compiling committee.c: too many arguments to function