From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N64sd-0006qA-6Z for qemu-devel@nongnu.org; Thu, 05 Nov 2009 11:08:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N64sX-0006ne-Bi for qemu-devel@nongnu.org; Thu, 05 Nov 2009 11:08:10 -0500 Received: from [199.232.76.173] (port=58297 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N64sX-0006nW-1e for qemu-devel@nongnu.org; Thu, 05 Nov 2009 11:08:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26089) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N64sW-0005d1-Fo for qemu-devel@nongnu.org; Thu, 05 Nov 2009 11:08:04 -0500 Message-ID: <4AF2F85E.6020603@redhat.com> Date: Thu, 05 Nov 2009 18:07:58 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qemu References: <1257294485-27015-1-git-send-email-aliguori@us.ibm.com> <4AF2E247.3090409@redhat.com> <4AF2E7CE.8010506@us.ibm.com> <4AF2EB17.8090202@redhat.com> <4AF2F04B.8050105@redhat.com> <4AF2F63C.6060204@us.ibm.com> In-Reply-To: <4AF2F63C.6060204@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , Arnd Bergmann , Dustin Kirkland , Juan Quintela , qemu-devel@nongnu.org, Michael Tsirkin On 11/05/2009 05:58 PM, Anthony Liguori wrote: >> Having the tap accessible to management also allows it to run tcpdump >> or collect statistics on it at runtime. > > I'm not advocating removing -net tap,fd=. But -net bridge is > obviously useful and makes writing management tools that do common > things easier. Not doing something that helps management tools and > command line users tremendously simply because it's possible to do it > another way for management tools (but not for command line users) is > almost user hostile. > As your patchset shows, it's not "tremendously" difficult. The basic helper (which is all libvirt would need; plus PolicyKit integration) is 200 lines. I don't see why you consider placing functionality in the management stack vs qemu user hostile, considering who our users are. -- error compiling committee.c: too many arguments to function