From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7QEq-00085n-He for qemu-devel@nongnu.org; Mon, 09 Nov 2009 04:08:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7QEm-00083q-1d for qemu-devel@nongnu.org; Mon, 09 Nov 2009 04:08:40 -0500 Received: from [199.232.76.173] (port=42282 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7QEl-00083m-UW for qemu-devel@nongnu.org; Mon, 09 Nov 2009 04:08:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39391) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N7QEl-0007oL-Cr for qemu-devel@nongnu.org; Mon, 09 Nov 2009 04:08:35 -0500 Message-ID: <4AF7DC02.2070308@redhat.com> Date: Mon, 09 Nov 2009 10:08:18 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [sneak preview] major scsi overhaul References: <4AF4ACA5.2090701@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: "qemu-devel@nongnu.org" On 11/07/09 16:22, Blue Swirl wrote: > In general the commits look good, there are many obviously correct cleanups. > > However, what happens to the DPRINTFs, it looks like they are removed > in the process? I guess you are talking about the ones for each emulated command in scsi-disk.c? There is scsi_print_req() now, filling this hole. I'll stick in a call, wrapped into #ifdef DEBUG_SCSI, so you'll get this printed by default when compiling with debugging enabled. > You are also moving the compilation to Makefile.hw, which is not > exactly an improvement. Is this needed because of the QEMUIOVector > stuff? Almost correct ;) It is because of QEMUSGList which drags in a target_phys_addr_t dependency. cheers, Gerd