From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7dZC-0000Gu-EE for qemu-devel@nongnu.org; Mon, 09 Nov 2009 18:22:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7dZ7-00008j-Bq for qemu-devel@nongnu.org; Mon, 09 Nov 2009 18:22:33 -0500 Received: from [199.232.76.173] (port=55005 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7dZ7-00008W-5D for qemu-devel@nongnu.org; Mon, 09 Nov 2009 18:22:29 -0500 Received: from e6.ny.us.ibm.com ([32.97.182.146]:39201) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N7dZ6-0006FS-Uf for qemu-devel@nongnu.org; Mon, 09 Nov 2009 18:22:29 -0500 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e6.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id nA9NRvgV023621 for ; Mon, 9 Nov 2009 18:27:57 -0500 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nA9NMRDg117474 for ; Mon, 9 Nov 2009 18:22:27 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nA9NMQDo011087 for ; Mon, 9 Nov 2009 18:22:27 -0500 Message-ID: <4AF8A431.3040607@us.ibm.com> Date: Mon, 09 Nov 2009 17:22:25 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <204026d59328febd9789.1257800737@localhost.localdomain> <4AF893BC.2040507@web.de> In-Reply-To: <4AF893BC.2040507@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: hollisb@linux.vnet.ibm.com, kvm-ppc , qemu-devel Jan Kiszka wrote: > Hollis Blanchard wrote: > >> Unbreaks PowerPC and S390 KVM builds. >> > > What breaks precisely? > > Note that KVM_GET/SET_MP_STATE are generic IOCTLs and supposed to be > shared with ia64 - one day. We could still move things back then, but > maybe we can handle the build issues already in place, specifically as > qemu-kvm is carrying this in generic code since ages. > mp_state is pretty specific to the in-kernel apic. ia64 may share because it shares an interrupt controller but that does not make it generic. That just makes two architectures have a common field. I don't think there's anything wrong with kvm exposing this as a common ioctl but from a qemu perspective, it makes no sense as a common cpu field. It only makes sense when using kvm and when using an in-kernel apic. That's very architecture specific from an qemu perspective. -- Regards, Anthony Liguori