From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7s1N-0006W0-9Y for qemu-devel@nongnu.org; Tue, 10 Nov 2009 09:48:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7s1J-0006UR-0H for qemu-devel@nongnu.org; Tue, 10 Nov 2009 09:48:36 -0500 Received: from [199.232.76.173] (port=57369 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7s1I-0006U7-2U for qemu-devel@nongnu.org; Tue, 10 Nov 2009 09:48:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47153) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N7s1H-0001uy-GY for qemu-devel@nongnu.org; Tue, 10 Nov 2009 09:48:31 -0500 Message-ID: <4AF97D3B.8080601@redhat.com> Date: Tue, 10 Nov 2009 16:48:27 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer References: <1257845850-4660-1-git-send-email-scottt.tw@gmail.com> <1257845850-4660-2-git-send-email-scottt.tw@gmail.com> <1257845850-4660-3-git-send-email-scottt.tw@gmail.com> In-Reply-To: <1257845850-4660-3-git-send-email-scottt.tw@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Tsai Cc: qemu-devel@nongnu.org On 11/10/2009 11:37 AM, Scott Tsai wrote: > Emulate the Vernier Go!Temp USB thermometer > (see: http://www.vernier.com/go/gotemp.html) > used in Greg Kroah-Hartman's "Write a Real, Working, Linux Driver" talk. > > The emulation is complete enough for gregkh's sample driver and > using the vendor supplied SDK through the in-kernel 'ldusb' module under Linux. > No testing have yet been done with the vendor's fancier Windows software. > > + s->temperature++; > You're going to overheat very quickly. Apart from making the driver work, is this actually useful? -- error compiling committee.c: too many arguments to function