From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N80mn-0007fA-8m for qemu-devel@nongnu.org; Tue, 10 Nov 2009 19:10:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N80mh-0007dG-6H for qemu-devel@nongnu.org; Tue, 10 Nov 2009 19:10:07 -0500 Received: from [199.232.76.173] (port=52814 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N80mh-0007d8-1G for qemu-devel@nongnu.org; Tue, 10 Nov 2009 19:10:03 -0500 Received: from qw-out-1920.google.com ([74.125.92.146]:34654) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N80mg-0007lJ-MP for qemu-devel@nongnu.org; Tue, 10 Nov 2009 19:10:02 -0500 Received: by qw-out-1920.google.com with SMTP id 5so107253qwc.4 for ; Tue, 10 Nov 2009 16:10:02 -0800 (PST) Message-ID: <4AFA00D6.9030107@codemonkey.ws> Date: Tue, 10 Nov 2009 18:09:58 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer References: <1257845850-4660-1-git-send-email-scottt.tw@gmail.com> <1257845850-4660-2-git-send-email-scottt.tw@gmail.com> <1257845850-4660-3-git-send-email-scottt.tw@gmail.com> <4AF97D3B.8080601@redhat.com> <374D220D-FE6E-410B-83F3-E8988BA61A6D@suse.de> <20091110150630.19b0c3fa@doriath> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Tsai Cc: Alexander Graf , Avi Kivity , qemu-devel@nongnu.org, Luiz Capitulino Scott Tsai wrote: > On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino wrote: > >>> I'd certainly like to make this code useful for something other than >>> developer training. >>> How about a new monitor command "thermometer_set" that works like "mouse_move"? >>> "thermometer_set" would just set the temperature of the "first" >>> thermometer device it finds. >>> >> Couldn't the device be a parameter? >> >> And I'd suggest usb_therm_set for the name. >> >> > > Looking at the existing "mouse_set" and "mouse_move" monitor commands, > they work on USB, PS/2 and other kinds of mice with "mouse_set" selecting > the mouse device affected by "mouse_move". > So how about a new command "therm_set" which selects the thermometer > affected by "therm_temp" ? > > On a separate note, I understand that if a piece of code is not useful enough > we don't want to merge it to add to the maintenance burden. > I still propose 'usb-gotemp' for merging because the fact that gregkh > could give his > driver tutorial several years in a roll to sizable audiences shows > that there are people out there > interested in getting into Linux driver development. > With this code merged, people could follow the video and slides of his talk > without special hardware and this potentially grows the Linux developer pool. > And if Greg decides to change the device he uses for the tutorial, then in a few years it's not so useful anymore? That said, if we position this as an example device, I think that makes sense. But that suggests that we should document the heck out of it and make it a learning experience for QEMU too. It could be an example of how to write a simple QEMU device emulation. That would be interesting independent of Greg's tutorial. Regards, Anthony Liguori