From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8Bkr-0005ZZ-MA for qemu-devel@nongnu.org; Wed, 11 Nov 2009 06:52:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8Bkm-0005VS-2x for qemu-devel@nongnu.org; Wed, 11 Nov 2009 06:52:52 -0500 Received: from [199.232.76.173] (port=46574 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8Bkl-0005Uo-I5 for qemu-devel@nongnu.org; Wed, 11 Nov 2009 06:52:47 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57252 helo=mx2.suse.de) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8Bkl-0002HC-3I for qemu-devel@nongnu.org; Wed, 11 Nov 2009 06:52:47 -0500 Message-ID: <4AFAA58B.6090907@suse.de> Date: Wed, 11 Nov 2009 12:52:43 +0100 From: Hannes Reinecke MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul References: <4AF4ACA5.2090701@redhat.com> <4AFA9E36.3030507@redhat.com> In-Reply-To: <4AFA9E36.3030507@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "qemu-devel@nongnu.org" Gerd Hoffmann wrote: > On 11/07/09 00:09, Gerd Hoffmann wrote: >> Hi, >> >> http://repo.or.cz/w/qemu/kraxel.git/shortlog/refs/heads/scsi.v6 >=20 > Pushed an update, same branch. >=20 >> What needs to be done? >> >> (1) Better patch descriptions. >> (2) Submit patches to the list for review. >=20 > Still to do. Also: >=20 > - fold incremental fixes into the original patches. Will happen next > time I rebase the patches. > - Also SCSI_XFER_* will be loose the META/DATA separation, it will > only be "none / from device / to device". Also planned for the next > rebase. >=20 Thanks. I'm rediffing my megasas driver. I still don't quite agree with the new scsi callback, which has just the SCSIRequest as an argument. So when supporting more command queueing we have no idea to which (internal) request structure the SCSIRequest belongs, and still have to do a lookup. Which is painful. Can we have a second 'void *arg' argument to the callback which will allow us some driver specific pointer? >> (3) Switch over lsi to the new interface. >> (4) Zap old interface, killing tons of dead code. >> (5) Final cleanups. >=20 > All done now. So the final code tree is almost where I want to have it= , > although the patches series need some more work to be review-able. >=20 I have two more patches here, one to support more than 8 SCSI devices. And another one updating the scsi-generic infrastructure to latch on any device supporting SG_IO. Will be posting them soon. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Markus Rex, HRB 16746 (AG N=FCrnberg)