From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8Cqf-0001zF-Tv for qemu-devel@nongnu.org; Wed, 11 Nov 2009 08:02:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8Cqb-0001vd-AL for qemu-devel@nongnu.org; Wed, 11 Nov 2009 08:02:57 -0500 Received: from [199.232.76.173] (port=38333 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8Cqb-0001vT-0n for qemu-devel@nongnu.org; Wed, 11 Nov 2009 08:02:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45146) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8Cqa-0005DW-Cn for qemu-devel@nongnu.org; Wed, 11 Nov 2009 08:02:52 -0500 Message-ID: <4AFAB5F8.50209@redhat.com> Date: Wed, 11 Nov 2009 14:02:48 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul References: <4AF4ACA5.2090701@redhat.com> <4AFA9E36.3030507@redhat.com> <4AFAA58B.6090907@suse.de> In-Reply-To: <4AFAA58B.6090907@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: "qemu-devel@nongnu.org" On 11/11/09 12:52, Hannes Reinecke wrote: > I still don't quite agree with the new scsi callback, which has > just the SCSIRequest as an argument. So when supporting more command > queueing we have no idea to which (internal) request structure > the SCSIRequest belongs, and still have to do a lookup. > Which is painful. Can we have a second 'void *arg' argument > to the callback which will allow us some driver specific > pointer? How about sticking a 'void *hba_private' element into SCSIRequest instead? cheers, Gerd